Copy nonlinear fit input arrays into the cache struct#117
Open
JamesWrigley wants to merge 1 commit into
Open
Conversation
So that we don't accidentally overwrite the input when using the caches directly and calling `reinit!()` on them.
Comment on lines
+12
to
+17
| ### Fixed | ||
| - Changed the solver for [`NonlinearCurveFitProblem`](@ref) to make copies of | ||
| the input arrays into its internal cache so that the original input arrays | ||
| won't be overwritten if `reinit!(cache; x, y, sigma)` is called | ||
| ([#117]). Doing one-off solves will incur extra allocations due to the copy, | ||
| reusing the cache remains as efficient as before. |
Member
There was a problem hiding this comment.
We should probably us an AbstractAliasSpecifier with the alias kwarg, i.e. the SciMLBase aliasing interface, for this package to control this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So that we don't accidentally overwrite the input when using the caches directly and calling
reinit!()on them.Note that the code already makes a copy of
uwhen creating the solution, so that's not aliased. I considered making that aliasing as well but decided it would be too confusing since I could definitely see situations where people callreinit!()+solve!()in a loop and pushuto an array or something.Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.